[Pki-devel] [PATCH] 170-172 formatting and improvements to security domain python api

[Endi Sukma Dewata]

On 5/9/2014 11:04 AM, Abhishek Koneru wrote:
> 170:
> -- Replacing the get methods in KeyInfo and KeyRequestInfo to property
> type
>
> @property
> def request_id(self):
>      if self.requestURL is not None:
>          indx = str(self.requestURL).rfind("/") + 1
>          return str(self.requestURL)[indx:]
>      return None

This looks like something that can be done to most/all get_* methods. 
Probably separate patch?

> Other than that. ACK from me for all three patches.
>
> --Abhishek

In patch #172, in the Python API the SecurityDomainInfo uses a dict 
called 'systems' to map the subsystem name to the list of 
SecurityDomainHosts. In the Java API the DomainInfo it uses a map is 
called 'subsystems' to map the subsystem name to SecurityDomainSubsystem 
which contains another map of hosts. So the map name & the structure are 
different. Is this intentional? Do we need to change the Java API to 
match the Python API?

-- 
Endi S. Dewata