[Pki-devel] [PATCH] TomcatJSS - NullPointerException in tomcatjss searching for attribute "clientauth"

[Christina Fu]

This is the fix for the following upstream tomcatjss bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1052417

The fix is simply fixing the NullPointerException issue by giving 
"clientauth" directive a default of "want".
This will cause the desired default behavior for Dogtag servers.

thanks,
Christina


-------------- next part --------------
Index: src/org/apache/tomcat/util/net/jss/JSSSocketFactory.java
===================================================================
--- src/org/apache/tomcat/util/net/jss/JSSSocketFactory.java	(revision 278)
+++ src/org/apache/tomcat/util/net/jss/JSSSocketFactory.java	(working copy)
@@ -405,6 +405,10 @@
             // MUST look for "clientauth" (ALL lowercase) since "clientAuth"
             // (camel case) has already been processed by Tomcat 7
             String clientAuthStr = (String)endpoint.getAttribute("clientauth");
+            if (clientAuthStr == null) {
+                debugWrite("JSSSocketFactory init - \"clientauth\" not found, default to want.");
+                clientAuthStr = "want";
+            }
             File file = null;
             try {
                 mServerCertNickPath = (String)endpoint.getAttribute("serverCertNickFile");
Index: tomcatjss.spec
===================================================================
--- tomcatjss.spec	(revision 278)
+++ tomcatjss.spec	(working copy)
@@ -1,6 +1,6 @@
 Name:     tomcatjss
 Version:  7.1.0
-Release:  4%{?dist}
+Release:  5%{?dist}
 Summary:  JSSE implementation using JSS for Tomcat
 URL:      http://pki.fedoraproject.org/
 License:  LGPLv2+