[Pki-devel] [pki-devel][PATCH] 0023-Provide-standalone-Pin-Reset-Processor.patch

[John Magne]

Based on cfu's
conditional ACK.

Fixed minor issue, tested and pushed to master.

Closing ticked #877 TPS Rewrite: Token Pin Reset Operation



----- Original Message -----
> From: "Christina Fu" <cfu at redhat.com>
> To: pki-devel at redhat.com
> Sent: Monday, September 22, 2014 9:24:37 AM
> Subject: Re: [Pki-devel] [pki-devel][PATCH]	0023-Provide-standalone-Pin-Reset-Processor.patch
> 
> I see you moved checkAndAuthenticateUser() from TPSEnrollProcessor to
> TPSProcessor to be shared by other ops, which makes sense. However, the
> configName that it retrieves from the config store still has
> TPSEngine.OP_ENROLL_PREFIX in it. Wouldn't that need to be changed to the
> current op, whichever is calling?
> 
> Christina
> 
> On 09/19/2014 11:26 AM, John Magne wrote:
> 
> 
> 
> Resubmitting, because I failed to call the authentication step for the pin
> reset operation.
> Also added a few sanity checks to make sure the token is eligible to have its
> pin reset.
> 
> 
> ----- Original Message -----
> 
> 
> 
> From: "John Magne" <jmagne at redhat.com> To: "pki-devel" <pki-devel at redhat.com>
> Sent: Thursday, September 18, 2014 5:24:50 PM
> Subject: [Pki-devel] [pki-devel][PATCH]
> 0022-Provide-standalone-Pin-Reset-Processor.patch
> 
> Author: Jack Magne <jmagne at dhcp-16-213.sjc.redhat.com> Date:   Thu Sep 18
> 17:11:07 2014 -0700
> 
>     Provide standalone Pin Reset Processor.
>     
>     Now an enrolled token can have its pin changed with esc without doing
>     another enrollment.
>     Simply select "Reset Password" in esc, when using an enrolled token.
> 
> 
> Tested to work.
> _______________________________________________
> Pki-devel mailing list Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> _______________________________________________
> Pki-devel mailing list Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
> 
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel