[Pki-devel] patch to add nuxwdog support to tomcatjss
Christina Fu
cfu at redhat.com
Mon Apr 20 22:33:11 UTC 2015
other than the null pointer, I also suspect that this patch might not be
cross-platform (or cross-tomcat-version, rather). I do recall that at
some point in the past when attr doesn't exist in
endpoint.getAttribute(attr), it throws an exception instead of returning
a null. You might want to consider putting the changes from try/catch
block to (the to-be-added) null checks in a separate patch.
Christina
On 04/20/2015 02:21 PM, Ade Lee wrote:
> One small change .. See attached patch instead.
>
> Ade
> On Mon, 2015-04-20 at 17:06 -0400, Ade Lee wrote:
>> This patch adds nuxwodg support to tomcatjss. In addition, it cleans up
>> some of the init code for tomcatjss, especially with regards to
>> initializing the password store and logging into tokens.
>>
>> This patch is still untested - so its just a preview. But I expect the
>> final patch to look very similar to this one.
>>
>> Ade
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20150420/b57d4d21/attachment.htm>
More information about the Pki-devel
mailing list