[Pki-devel] [PATCH] 0031..0033 minor LDAPProfileSubsystem fixes

Endi Sukma Dewata edewata at redhat.com
Mon Apr 13 17:21:10 UTC 2015


ACK for #31 & #33.

On 4/13/2015 1:12 AM, Fraser Tweedale wrote:
> profileId = new X500Name(dn).getCommonName();

For #32, I don't think we should use X500Name since this is a generic 
LDAP DN, not necessarily a DN in a certificate. There may be multiple 
CN's in a generic DN (e.g. cn=...,cn=...,dc=example,dc=com).

Probably it should be like this:

     // assuming DN: cn=<profileId>,...
     profileId = LDAPDN.explodeDN(dn, true)[0];

-- 
Endi S. Dewata




More information about the Pki-devel mailing list