[Pki-devel] [PATCH 022] Modernize for Python 3 support
Christian Heimes
cheimes at redhat.com
Mon Aug 17 05:54:55 UTC 2015
Ade,
thanks for your review of my gigantic patch set.
On 2015-08-14 21:21, Ade Lee wrote:
> Went through the 15 patches. Looks pretty straightforward and acks for
> the first 12 and the last patch, which the following comment:
>
> 1. Please add comments to describe some of the changes being made so
> that we have a record for later on.
>
> This is particularly true for things like adding absolute_import
> (which doesn't have a reference in the code and someone might be
> tempted to remove in future).
Your and Endi's review have shown me that several small patches are
easier to understand and better to read than a large, squashed patch
bomb. I will post a series of smaller patches later. Each patch will a
long description
> On patch 13 - Manually fix import problems and access to
> Exception.message, I have the following question:
>
> 2. In base/server/python/pki/server/deployment/pkiparser.py and in
> base/common/python/pki/key.py, you solve the import problem for
> urllib by trying to import the Python2 first and then Python 3
> (or visa versa). Why doesn't importing the relevant six module
> work instead?
I don't mind to use six.moves here, too. I guess I'm used to manual
imports with try/except ImportError. I've to disable pylint warnings
anyway as pylint doesn't understand six.moves magic.
>
> And on patch 14 (sepolgen):
>
> 3. Could you explain what the effect of your sepolgen change is?
It's a temporary workaround for an incomplete Python 3 package. It
disables the SELinux policy generator in pkispawn until the package is
fixed. As a consequence you have to disable SELinux enforcement -- but
only for pkispawn and pkidestroy on Python 3. It doesn't affect the
regular Python 2.7 code.
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20150817/8659670c/attachment.sig>
More information about the Pki-devel
mailing list