[Pki-devel] [PATCH] 661 Fixed selftest error handling.

Endi Sukma Dewata edewata at redhat.com
Wed Dec 2 01:23:18 UTC 2015


On 12/1/2015 5:59 PM, Christina Fu wrote:
> looks fine.  ACK.

Thanks! Pushed to master.

> One little thing you might want to consider.  In CMSAdminServlet.java,
> you have
>
> +                CMS.debug(e);
>
> you might want to add info on what file/method you are at so that the
> debug message will come out stating exactly where it is at in the code.

The above statement will actually log the stack trace which will show 
the origin of the exception. I also added a debug log before calling 
verifySystemCertByNickname() so we know where we are. If this is not 
sufficient please let me know, we can add it in a separate patch.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list