[Pki-devel] [PATCH] 551 Fixed pylint report.

Fraser Tweedale ftweedal at redhat.com
Thu Feb 5 05:36:53 UTC 2015


On Wed, Feb 04, 2015 at 01:53:28PM -0600, Endi Sukma Dewata wrote:
> Previously pylint report was saved it into a file which may not be
> accessible on a build system. The pylint-build-scan.sh has been
> changed to display the report so it will appear in the build log.
> 
> The pylint configuration has also been modified to disable C and R
> messages by default. This way when other errors or warnings occur
> the build will fail without having to check for specific codes.
> 
> Some Python codes have been modified to reduce the number of pylint
> warnings.
> 
> https://fedorahosted.org/pki/ticket/703
> 
> -- 
> Endi S. Dewata

> From 5ad084208d5450cbab7c7cabeed60354d74bd564 Mon Sep 17 00:00:00 2001
> From: "Endi S. Dewata" <edewata at redhat.com>
> Date: Fri, 30 Jan 2015 15:49:27 -0500
> Subject: [PATCH] Fixed pylint report.
> 
> Previously pylint report was saved it into a file which may not be
> accessible on a build system. The pylint-build-scan.sh has been
> changed to display the report so it will appear in the build log.
> 
> The pylint configuration has also been modified to disable C and R
> messages by default. This way when other errors or warnings occur
> the build will fail without having to check for specific codes.
> 
> Some Python codes have been modified to reduce the number of pylint
> warnings.
> 
> https://fedorahosted.org/pki/ticket/703
>  
> -            if param in {
> -                'email', 'common_name', 'user_id', 'org_unit', 'org',
> -                'locality', 'state', 'country', 'match_exactly'
> +            if param in {\
> +                'email', 'common_name', 'user_id', 'org_unit', 'org',\
> +                'locality', 'state', 'country', 'match_exactly'\

Yuck!  Can we disable this pylint warning codebase-wide?

I've eyeballed the patch and it seems fine; ACK if tested.

Fraser




More information about the Pki-devel mailing list