[Pki-devel] [PATCH] Bugzilla Bug #1147924 - dogtag: syntax errors in /usr/share/pki/scripts/operations

[Fraser Tweedale]

On Wed, Jan 07, 2015 at 07:36:36PM -0700, Matthew Harmsen wrote:
> Please review the attached patch which addresses the following bug:
> 
>  * Bugzilla Bug #1147924 - dogtag: syntax errors in
>    /usr/share/pki/scripts/operations
>    <https://bugzilla.redhat.com/show_bug.cgi?id=1147924>
> 
> 
ACK

> From 5670a1f115c0d50b86ade800cbe999a49e79d4e7 Mon Sep 17 00:00:00 2001
> From: Matthew Harmsen <mharmsen at redhat.com>
> Date: Wed, 7 Jan 2015 16:04:45 -0700
> Subject: [PATCH] Fixed bash syntax error
> 
> - Bugzilla Bug #1147924 - dogtag: syntax errors in
>   /usr/share/pki/scripts/operations
> ---
>  base/server/scripts/operations | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/base/server/scripts/operations b/base/server/scripts/operations
> index 2093691..f524a55 100644
> --- a/base/server/scripts/operations
> +++ b/base/server/scripts/operations
> @@ -1469,7 +1469,7 @@ backup_instance_configuration_files()
>              echo "WARNING:  The '${pki_instance_configuration_file}' is empty!"
>              echo "          ${PKI} backups will be discontinued until this"
>              echo "          issue has been resolved!"
> -            $((backup_errors++))
> +            ((backup_errors++))
>              continue
>          fi
>  
> @@ -1483,7 +1483,7 @@ backup_instance_configuration_files()
>              echo "WARNING:  Since the file '${saved_backup_file}' exists, a"
>              echo "          previous backup attempt has failed!  ${PKI} backups"
>              echo "          will be discontinued until this issue has been resolved!"
> -            $((backup_errors++))
> +            ((backup_errors++))
>              continue
>          fi
>  
> @@ -1530,7 +1530,7 @@ backup_instance_configuration_files()
>              echo "          which suggests that the previous backup file has"
>              echo "          been removed!  ${PKI} backups will be discontinued"
>              echo "          until this issue has been resolved!"
> -            $((backup_errors++))
> +            ((backup_errors++))
>              continue
>          fi
>  
> @@ -1561,7 +1561,7 @@ backup_instance_configuration_files()
>              if [ ! -s ${archived_file} ] ; then
>                  # Issue a warning that the archived backup failed
>                  echo "WARNING:  Failed to archive '${pki_instance_configuration_file}' to '${archived_file}'!"
> -                $((backup_errors++))
> +                ((backup_errors++))
>                  continue
>              fi
>  
> @@ -1576,7 +1576,7 @@ backup_instance_configuration_files()
>          if [ ! -s ${backup_file} ] ; then
>              # Issue a warning that the backup failed
>              echo "WARNING:  Failed to backup '${pki_instance_configuration_file}' to '${backup_file}'!"
> -            $((backup_errors++))
> +            ((backup_errors++))
>              continue
>          else
>              # Report that 'CS.cfg' has been successfully backed up
> -- 
> 1.8.3.1
> 

> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel