[Pki-devel] [PATCH] 544 Added server management library.

[Endi Sukma Dewata]

Thanks for the review. Comments below.

On 1/26/2015 9:44 PM, Fraser Tweedale wrote:
> Tested in conjection with 545.
> ACK modulo comments:
>
> 1. Subsystem enable/disable requires instance restart to take
>     effect.  If this is intended/unavoidable, that's fine, but could be
>     made clearer.

Actually with patch #531-3 and #545 the webapp auto deploy will be 
activated, so enabling/disabling subsystem should take effect in a few 
seconds automatically, no restart is needed. When auto deploy is 
enabled, Tomcat will monitor the <instance>/conf/Catalina/localhost 
folder to see if a webapp deployment descriptor is added or deleted, 
then it will deploy/undeploy the webapp accordingly.

Alternatively we probably can use JMX, but that will require some 
investigation:
https://fedorahosted.org/pki/ticket/1246

> 2. What are the implications for Debian/Ubuntu with hardedcoded
>     calls to systemctl?  Could you dispatch to systemctl/service/upstart
>     as appropriate?

The code is at least initially written for Fedora. I'm not sure if it 
will work on Debian/Ubuntu, perhaps someone familiar with it could help. 
If there's a reliable way to detect the distribution we probably can 
generate the proper command for each distribution.

-- 
Endi S. Dewata