[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pki-devel] [PATCH] 547 Refactored CRMFPopClient.



Looks nice. Thinks are much simpler.


Quick Comments/Questions:

1. Looks like we've added a command line param for the transport cert.
I notice there is still a check to see if the number of params is 4 or more.
Is this still valid, or is the transport cert param optional?

2. Down in the code where we are generating keys either ec or rsa, we still
check to see if the algorithm is valid. Was this check not already done at the top
of the method?

3. Inside "submitRequest" you have some System.out.println's lingering. Was the idea to
get rid of all of those?

4. Does the usage string give an idea what params are optional and such? If not would this be
helpful? Is it the "default" designation used for this purpose?


Anyway, ACK on the functionality if its been of course tested to work.



----- Original Message -----
> From: "Endi Sukma Dewata" <edewata redhat com>
> To: "pki-devel" <pki-devel redhat com>
> Sent: Tuesday, January 27, 2015 11:31:45 AM
> Subject: [Pki-devel] [PATCH] 547 Refactored CRMFPopClient.
> 
> The CRMFPopClient has been refactored such that it is easier
> to understand and reuse. The code has been fixed such that it
> can read a normal PEM transport certificate. It also has been
> fixed to parse the request submission result properly.
> 
> The client-cert-request CLI command was modified to support CRMF
> requests.
> 
> The MainCLI and ClientConfig were modified to accept a security
> token name.
> 
> The pki_java_command_wrapper.in was modified to include the Apache
> Commons IO library.
> 
> https://fedorahosted.org/pki/ticket/1074
> 
> --
> Endi S. Dewata
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel redhat com
> https://www.redhat.com/mailman/listinfo/pki-devel


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]