[Pki-devel] [PATCH] Ticket#1028 Phase1:TPS rewrite: provide externalReg functionality

Christina Fu cfu at redhat.com
Fri Jan 30 18:48:31 UTC 2015


attached please find the Phase 1 code for
https://fedorahosted.org/pki/ticket/1028
  Ticket#1028 TPS rewrite: provide externalReg functionality

Due to a recent change of task priorities, I am to check in this feature 
in two phases (coming back to phase 2 at a later time).
In this Phase 1, the code for this feature is in place, but may not be 
in the most optimal condition.
The goal for Phase 1 is to:

1. not break existing functionality (non ExternalReg -- which is default)
2. when ExternalReg is turned on, it works for the basic case (didn't
test for more complicated cases)... e.g. I don't know if say an existing
cert on the token is missing from the externalReg user record, whether
it will be removed or not.
3. it is not guaranteed to work with more complicated scenario
4. code has been run through and cleaned up in Eclipse

Later, for Phase 2:

1. really clean up and add bells and whistles (more error checkings, more efficient code,
proper logging, etc.)
2. test/cover all cases

Jack has already helped testing it with a real token with ExternalReg turned off (didn't seem to break the existing functionalities);
Jack has also helped testing it with a real token with ExternalReg turned on for simple enrollment/recovery

and Jack is going to review this Phase 1 code.  Thank you Jack!

Christina


-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-cfu-0041-Ticket-1028-Phase1-TPS-rewrite-provide-externalReg-f.patch
Type: text/x-patch
Size: 124768 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20150130/9edf2e1f/attachment.bin>


More information about the Pki-devel mailing list