[Pki-devel] [PATCH] 634 Updated man pages with TPS info.

[John Magne]

ACK.

This is just for the tps shared secret part, looks fine.

If we have precedent for linking back to docs this is fine.
Although the instructions are short enough, we might put them
in the text itself, but no big deal.





----- Original Message -----
> From: "Endi Sukma Dewata" <edewata at redhat.com>
> To: pki-devel at redhat.com, "Christina Fu" <cfu at redhat.com>
> Sent: Friday, July 17, 2015 4:37:23 PM
> Subject: Re: [Pki-devel] [PATCH] 634 Updated man pages with TPS info.
> 
> On 7/17/2015 11:36 AM, Christina Fu wrote:
> > 1. I don't think we should assume that the installer is root.  I suggest
> > you change the following line from
> > setup the path where the admin certificate of this <subsystem> should be
> > stored. The default value is
> > /root/.dogtag/pki-tomcat/<ca/kra/ocsp/tks/tps>_admin.cert.
> > to something like
> > setup the path where the admin certificate of this <subsystem> should be
> > stored. The default value is
> > $HOME/.dogtag/pki-tomcat/<ca/kra/ocsp/tks/tps>_admin.cert.
> > If there are other places like this in this man pages or any other
> > documentation, we should make sure we do this correct.y
> 
> This is fixed in patch #635 (ACKed by alee).
> 
> > 2. I do not find any mentioning of the need to set up the shared secret
> > between TKS and TPS after pkispawn if one were to install TKS and TPS on
> > separate tomcat instances.  Please add that as a note and point to
> > wherever the detail is at(possibly another tps-specific man page).  Can
> > also mention that in the case of shared tomcat instance, pkispawn takes
> > cared of it.
> 
> Please take a look at the new patch #634-2. I added references to the
> instruction provided by jmagne.
> 
> > 3. probably no action needed from you now, but I need to write a man
> > page for TPS externalReg feature.
> >
> > We can discuss more on irc if needed.
> > thanks,
> > Christina
> 
> --
> Endi S. Dewata
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel