[Pki-devel] [PATCH] 007 In-tree tests and linting with tox

Endi Sukma Dewata edewata at redhat.com
Wed Jul 8 14:33:40 UTC 2015


On 7/1/2015 6:59 AM, Christian Heimes wrote:
> Hi,
>
> I don't like the fact that building and testing the Python part of PKI
> takes so long. I have been using tox and a custom setup.py for a couple
> of days now. The tox tool automates source distribution, virtual envs
> and testing. It makes it really easy to achieve a minium level of
> confidence, that the Python code is correct, in a matter of seconds.
>
> The patch is related to https://fedorahosted.org/pki/ticket/696 and
> https://fedorahosted.org/pki/ticket/708.
>
> How to use tox:
>
> $ sudo dnf install python-tox
> $ cd /path/to/pki/root
> $ tox
>
> Some useful options:
>
> Remove .tox directory and start with a refresh set of virtual environments:
>
> $ tox -r
>
> Just test one specific environment:
>
> $ tox -e lint
>
> Christian

The tox itself looks good, and hopefully in the future we can integrate 
it into the build system after addressing the "forced installation of 
sphinx in virtual env" on build machines as I mentioned on the IRC.

I just have one more question, the patch modifies the 
base/common/python/conf.py which is used by python-sphinx during build. 
How would this change affect the build? Is this change necessary for tox 
to work correctly?

-- 
Endi S. Dewata




More information about the Pki-devel mailing list