[Pki-devel] [PATCH] pkispawn man page ECC example
Matthew Harmsen
mharmsen at redhat.com
Sat Jul 11 00:11:02 UTC 2015
On 07/10/15 17:27, John Magne wrote:
> Looks good as is:
>
> Some minor suggestions..
>
> 1. The following line:
>
> For all PKI subsystems, ECC is not supported for the corresponding Audit Signing parameters.
>
> Might be a bit cleare to insert "including the CA", since the first part of the page talks about the CA
> and the second half discusses exceptions for other subystems, thus the user may assume.
Agreed - done.
>
> 2. It might be nice optionally to include a KRA sample if feasible.
Since we are considering example templates in the future, I won't add an
example for the KRA at this time.
> ACK with one semi required and 2 optional.
Pushed to 'master':
* baa3a78df1be63056b5e65123d1e3e2097fcb61e
<https://fedorahosted.org/pki/changeset/baa3a78df1be63056b5e65123d1e3e2097fcb61e/>
Thanks,
-- Matt
>
>
> ----- Original Message -----
>> From: "Matthew Harmsen" <mharmsen at redhat.com>
>> To: "pki-devel" <pki-devel at redhat.com>
>> Sent: Friday, July 10, 2015 3:03:33 PM
>> Subject: [Pki-devel] [PATCH] pkispawn man page ECC example
>>
>> Please review the following patch that addresses:
>>
>>
>> * PKI TRAC Ticket #1460 - Add 'pkispawn' man page example for ECC
>>
>>
>>
>>
>> _______________________________________________
>> Pki-devel mailing list
>> Pki-devel at redhat.com
>> https://www.redhat.com/mailman/listinfo/pki-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20150710/ee8578bd/attachment.htm>
More information about the Pki-devel
mailing list