[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pki-devel] [PATCH] 607 Fixed NPE in ROOT's index.jsp.



On 6/5/2015 8:50 PM, John Magne wrote:
This code looks good and appears to make sense.

Therefore ACK.

Thanks. Pushed to master.

Just a question though, did you come up with a test case to actually try this to
solve the issue?

I tested the changes on an instance where the problem already happens. I'm not sure what exactly caused it, but I'm suspecting the Tomcat's behavior has changed in the newer version. Regardless, the changes should make the code more robust.

--
Endi S. Dewata


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]