[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pki-devel] Replace legacy Python base64 invocations



On 6/29/2015 6:45 AM, Christian Heimes wrote:
Patch for https://fedorahosted.org/pki/ticket/1102

b64encode() and base64.encodestring() work slightly different.
encodestring() includes an extra newline at the end of the string. It
seems the server treats both representations equally.

I ran the KRA tests according to base/kra/functional/drmtest.readme.txt.
The tests are passing, too.

Christian

In drmclient_deprecated.py the extra '\n' is probably unnecessary:

  print "retrieved data is " + base64.b64encode(response['data']) + '\n'

Regardless, this file probably can be removed (check with alee).

ACK.

--
Endi S. Dewata


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]