[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Pki-devel] [PATCH] pki-cfu-0070-Ticket-1309-Recovering-of-a-revoked-cert-erroneously.patch

Looks good, some comments:

1. public void tdbAddCertificatesForCUID(String cuid, ArrayList<TPSCertRecord> certs, ExternalRegAttrs erAttrs)
+            throws TPSException {
+        String method = "TPSTokendb.tdbAddCertificatesForCUID (with erAttrs): ";
+        CMS.debug(method + "begins");
+        if (cuid == null || certs== null || certs.isEmpty() || erAttrs == null) {
+            CMS.debug(method + "params cuid, certs and erAttrs cannot be null or empty");
+        }

Here we do a bunch of sanity checking but fail to throw the exception.

2. There are a few TPSException(s) thrown but no code is specified, taking whatever the default is.

3. The little inner enum class should probably be positioned at the bottom on the class.

----- Original Message -----
From: "Christina Fu" <cfu redhat com>
To: pki-devel redhat com
Sent: Friday, May 22, 2015 5:34:30 PM
Subject: [Pki-devel] [PATCH]	pki-cfu-0070-Ticket-1309-Recovering-of-a-revoked-cert-erroneously.patch

This patch addresses issues reported in:
https://fedorahosted.org/pki/ticket/1309Recovering of a revoked cert 
erroneously reflects "active" in the token db cert entry

A new config param has been introduced to allow/disallow of recovering a 
revoked certificate for externalReg:
by default it is true

Please review.

Pki-devel mailing list
Pki-devel redhat com

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]