[Pki-devel] [PATCH] 0050 Lightweight CAs: ensure disabled CA cannot create sub-CA

Ade Lee alee at redhat.com
Fri Oct 2 18:35:18 UTC 2015


Conditional ACK.

The patch itself is fine.  However, its time we got into the habit of
adding functional tests for fixes we make.

We don't really have a good place for these, but there is a placeholder
location in the main_ function in the authority.py python file.  We
need to add some test code there.  We'll need to revamp these tests
soon and use the pytest framework, but we won't know to test this
condition unless the test case is there.

So, please add soem test code and confirm it works.

Ade

ps. You'll probably want to check in your delete patch and the correspo
nding python code first.


On Thu, 2015-10-01 at 13:53 +1000, Fraser Tweedale wrote:
> The attached patch (which replaces an earlier patch 0050) fixes
> https://fedorahosted.org/pki/ticket/1628.
> 
> Cheers,
> Fraser
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel




More information about the Pki-devel mailing list