[Pki-devel] [PATCH] 654 Removed unused WizardServlet.

[Endi Sukma Dewata]

On 10/21/2015 1:44 PM, Matthew Harmsen wrote:
> ACK

Thanks! Pushed to master with additional changes below.

> CAVEATS:
>
>   * In
>     'pki/base/server/cms/src/com/netscape/cms/servlet/csadmin/ConfigurationUtils.java',
>     please also change the initial comment from:
>
>     Utility class for functions to be used both by the RESTful installer
>     and the UI Panels
>
>     to simply:
>
>     Utility class for functions to be used by the RESTful installer

Fixed.

>   * Although several of our debug messages refer to various "Panels", I
>     believe that this is okay since the configuration servlet
>     (./base/server/cms/src/org/dogtagpki/server/rest/SystemConfigService.java)
>     still references these as a part of the configuration order

Fixed this too.

>   * We should file a new ticket which needs to be addressed after
>     https://fedorahosted.org/pki/ticket/1107 tpsclient re-write in which
>     we should probably remove/edit the following additional code under pki/:
>       o remove
>         ./base/server/cms/src/com/netscape/cms/servlet/csadmin/BaseServlet.java
>       o remove
>         ./base/server/cms/src/com/netscape/cms/servlet/csadmin/LoginServlet.java
>       o remove
>         ./base/server/cms/src/com/netscape/cms/servlet/csadmin/SecurityDomainLogin.java
>           + cleanup ./base/ca/shared/webapps/ca/WEB-INF/web.xml
>           + cleanup ./base/kra/shared/webapps/kra/WEB-INF/web.xml
>           + cleanup ./base/ocsp/shared/webapps/ocsp/WEB-INF/web.xml
>       o remove ./base/server/share/webapps/pki/admin (this is all of the
>         velocity templates)
>           + once pki/tps-client/ has been rewritten in Java, we can
>             probably remove this directory and also probably remove
>             dependencies on Velocity
>

Added a comment in https://fedorahosted.org/pki/ticket/1120.

-- 
Endi S. Dewata