[Pki-devel] [PATCH] 649 Refactored SecurityDomainProcessor.

Ade Lee alee at redhat.com
Thu Oct 8 21:34:36 UTC 2015


Looks like the only behavioral change is that the exception when a
hostname cannot be resolved to an IP is thrown, rather than being
swallowed up.  So two issues:

1) you've taken what was an optional parameter (because the IP test is
optional) and turned it into a required one.  That could break some
cases

2) when the breakage occurs, we do not know if its a client or server
issue.  So should this be a 400 or 500 error?

On Tue, 2015-10-06 at 17:49 -0500, Endi Sukma Dewata wrote:
> The SecurityDomainProcessor.getEnterpriseGroupName() has been
> added to simplify ConfigurationUtils.getGroupName().
> 
> The SecurityDomainProcessor.getInstallToken() has been modified
> to validate the user role and the IP address, and to generate
> safer session ID.
> 
> https://fedorahosted.org/pki/ticket/1633
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel




More information about the Pki-devel mailing list