[Pki-devel] [PATCH] 649 Refactored SecurityDomainProcessor.

Endi Sukma Dewata edewata at redhat.com
Tue Oct 13 17:21:53 UTC 2015


On 10/13/2015 10:55 AM, Endi Sukma Dewata wrote:
> On 10/8/2015 4:34 PM, Ade Lee wrote:
>> Looks like the only behavioral change is that the exception when a
>> hostname cannot be resolved to an IP is thrown, rather than being
>> swallowed up.  So two issues:
>>
>> 1) you've taken what was an optional parameter (because the IP test is
>> optional) and turned it into a required one.  That could break some
>> cases
>>
>> 2) when the breakage occurs, we do not know if its a client or server
>> issue.  So should this be a 400 or 500 error?
>
> New patch attached.
>
> Per IRC discussion the changes that added IP address validation have
> been reverted. Further discussion is needed to see if the IP address
> needs to be stored at all.

ACKed by alee. Pushed to master.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list