[Pki-devel] [PATCH] 713-716 Simplifying existing CA installation.

Ade Lee alee at redhat.com
Fri Apr 15 15:31:03 UTC 2016


ack on patches with a couple of small provisos.

1. Please ensure that IPA is not using the replaced parameters.  If so,
create a ticket to give them heads-up that they are changing.

2. Make sure man pages do not documents these replaced parameters.  If
so, fix them.  Otherwise add ticket to document these new parameters.
Man page fix if necessary can be a separate patch.

3. The last patch (716) moves a bunch of code to a different scriptlet.
 Thats fine, but please encapsulate that code in a helper function. 
 The spawn() functions are already too massive and need to be
refactored.

Ade 
On Fri, 2016-04-15 at 01:14 -0500, Endi Sukma Dewata wrote:
> Attached are the changes to simplify the existing CA installation:
> https://fedorahosted.org/pki/ticket/1736
> 
> The documentation has been updated:
> http://pki.fedoraproject.org/wiki/Installing_CA_with_Existing_CA_Cert
> ificate
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel




More information about the Pki-devel mailing list