[Pki-devel] [PATCH] 275 - remove dnsdomainname check

[Ade Lee]

Thanks for the check Endi.  Lets try this again.  

This time, we default instead to the hostname, instead of exiting.

Ade

On Tue, 2016-02-09 at 11:38 -0600, Endi Sukma Dewata wrote:
> On 2/9/2016 10:53 AM, Ade Lee wrote:
> > This check is unnecessary and is breaking continuous integration in
> > OpenStack.  Removing from pkispawn/pkidestroy.
> > 
> > Ade
> 
> If I'm reading the code correctly the pki_dns_domainname is used as a
> label to populate other properties (e.g. security domain names, admin
> email, nickname). While the label itself is not crucial to server 
> operations, the patch removes the code that's supposed obtain the
> proper 
> label. So under normal usage (i.e. outside CI) the pki_dns_domainname
> will be None, and those other properties will have incomplete values.
> 
> I think there are several options:
> 
> 1. Instead of removing the check, the code should assign a better 
> default value (e.g. example.com) to pki_dns_domainname if the domain 
> name is not available due to CI.
> 
> 2. Remove the check, but also remove all references to 
> pki_dns_domainname from the entire code.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-vakwetu-0276-Modify-dnsdomainname-test-in-pkispawn.patch
Type: text/x-patch
Size: 2675 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160210/20b9e94a/attachment.bin>