[Pki-devel] [PATCH 45/46] Run flake8 and pylint --py3k and fix violations

[Christian Heimes]

On 2016-01-25 06:42, Endi Sukma Dewata wrote:
> On 1/15/2016 7:06 AM, Christian Heimes wrote:
>> The first patch add flake8 tests and pylint --py3k to RPM build. The
>> second patch fixes a couple of flake8 violations that have accumulated
>> in the past month.
>>
>> I'm still having a problem with sphinx autodocs. It can't build
>> documentation for pki.crypto. It looks like autodocs doesn't do relative
>> imports correctly and picks up pki/nss.py as nss.
>>
>> SphinxWarning: /home/heimes/redhat/pki/base/common/python/pki.rst:39:
>> WARNING: autodoc: failed to import module u'pki.crypto'; the following
>> exception was raised:
>> Traceback (most recent call last):
>>    File
>> "/home/heimes/redhat/pki/.tox/docs/lib/python2.7/site-packages/sphinx/ext/autodoc.py",
>>
>> line 385, in import_object
>>      __import__(self.modname)
>>    File
>> "/home/heimes/redhat/pki/.tox/docs/lib/python2.7/site-packages/pki/crypto.py",
>>
>> line 26, in <module>
>>      import nss.nss as nss
>> ImportError: No module named nss
>>
>>
>> Christian
> 
> Patch #45 is ACKed.
> 
> Patch #46 needs a rebase due to renaming nss.py to nssdb.py which also
> fixes the above error. Also there's a new upgrade script
> base/server/upgrade/10.3.0/01-AllowEncodedSlash that needs a minor fix.
> Other than that it's ACKed.
> 
> These patches should be pushed together to avoid build breaks.

Thanks for the review.

I've rebased my local branch to the latest master, fixed
01-AllowEncodedSlash and pushed both patches on master in commits
0d2d97f9bf6802f6f81090eca6e135e50fea7883 (pylint and flake8 checks) and
cb6b0c4855885c03d056acb8f98c96de986e081e (fix violations).

Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160125/7b2b6f6d/attachment.sig>