[Pki-devel] [PATCH 0044 Don't use settings like HTTP proxy from env vars

[Christian Heimes]

On 2016-01-14 13:34, Christian Heimes wrote:
> The PKIConnection class uses python-requests for HTTPS. The library
> picks up several settings from environment variables, e.g. HTTP proxy
> server, certificate bundle with trust anchors and authentication. A
> proxy can interfere with the Dogtag installer and cause some operations
> to fail.
> 
> With session.trust_env = False python-requests no longer inspects the
> environment and Dogtag has full controll over its connection settings.
> 
> https://requests.readthedocs.org/en/latest/api/?highlight=trust_env#requests.Session.trust_env
> 
> https://fedorahosted.org/pki/ticket/1733
> https://fedorahosted.org/freeipa/ticket/5555

Endi suggested to keep the default and only disable trust_env in the
installer. Here is an updated patch.

Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pki-cheimes-0044-2-Dont-use-settings-like-HTTP-proxy-from-env-vars.patch
Type: text/x-patch
Size: 5163 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160119/5aef051d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160119/5aef051d/attachment.sig>