[Pki-devel] [PATCH 0009] More misc. fixes for pki-server commands

Endi Sukma Dewata edewata at redhat.com
Fri Jul 1 17:21:17 UTC 2016


On 7/1/2016 5:03 AM, Abhijeet Kasurde wrote:
> Hi All,
>
> Please find the patch for review.
>
> Partially fixes : https://bugzilla.redhat.com/show_bug.cgi?id=1351295
>
> --
> Thanks,
> Abhijeet Kasurde

Thanks! Pushed to master with some changes:

1. The instance.subsystems contains non-empty elements, so "not 
subsystem" will always be False. The db-schema-upgrade command requires 
that there is at least one subsystem in the instance, so the check is 
changed to "not instance.subsystems".

2. The bind password prompt is a nice addition. I moved it down after 
checking the instance and subsystem so we don't have to enter the 
password if the instance/subsystem is invalid.

-- 
Endi S. Dewata




More information about the Pki-devel mailing list