[Pki-devel] [PATCH] 765 Added TPS VLV management CLI.

[Ade Lee]

ACK

On Wed, 2016-06-08 at 13:02 -0500, Endi Sukma Dewata wrote:
> Thanks for the feedback. Please take a look at the new patches #765-1
> and #766.
> 
> On 6/8/2016 9:06 AM, Ade Lee wrote:
> > Looks pretty good.  A new and improved version of the KRA VLV CLIs
> > I
> > wrote last week.
> 
> As discussed on IRC the common code should be refactored in the
> future:
> https://fedorahosted.org/pki/ticket/2355
> 
> > tps-db-vlv-delete does not have a --generate-ldif option.  Are you
> > going to add that?
> 
> I've added an option to generate an LDIF file to delete old VLVs
> based 
> on the vlv.ldif (so it doesn't need to contact the server).
> 
> > Also, you should probably add a task to add a kra-db-vlv-find
> > option so
> > that we have parity.  We can set that for 10.4.
> 
> The kra-db-vlv-find has been added in the new patch. I also modified 
> kra-db-vlv-reindex to wait for the operation to complete.
> 
> The wiki page has been updated as well:
> http://pki.fedoraproject.org/wiki/Database_Upgrade_for_PKI_10.3.x#Fix
> ing_VLV_filters_and_sort_orders
>