[Pki-devel] [PATCH] 0076 Avoid XML parse fail with double-hyphen in hostname

[Endi Sukma Dewata]

On 3/2/2016 10:04 PM, Fraser Tweedale wrote:
> On Thu, Mar 03, 2016 at 11:40:15AM +1000, Fraser Tweedale wrote:
>> Attached patch fixes #1260: Installation fails due to double hyphen
>> "--" in hostname.
>>
>> Cheers,
>> Fraser
>>
> ACKed by Ade;
> pushed to master (8beb5cfa4cd81fbf47ea8cd6839b793c2a12284e)
>
> Cheers,
> Fraser

The patch changes "<!-- -->" into "<?pkidaemon ?>" in new instances 
only. Suppose in the future we write a script that parses "<?pkidaemon 
?>" (e.g. to remove the section) it would not be able to find it in an 
upgraded instance. Ideally there should be an upgrade script to change 
"<!-- -->" into "<?pkidaemon ?>" in existing instances too.

-- 
Endi S. Dewata