[Pki-devel] [pki-devel][PATCH] 0064-Port-symkey-JNI-to-Java-classes.patch

[Christina Fu]

Hi,
First of all, I have to say that Jack did a wonderful job on such 
daunting task.  The sheer amount of code and complexity does make the 
review more challenging, but I dug through them with my teeth and claws 
regardless ;-).

We discussed and think we should postpone the checkin to next release so 
we can make sure it gets the kind of attention in details that it deserves.

For the first round of reviews, I sent him two separate sets of review 
comments last week.  One for JSS, and one for the rest.
The JSS patch was not attached to his original email request for 
review.  It is attached to the following ticket:
https://fedorahosted.org/pki/ticket/801

You can find my review comments attached to this email.

thanks,
Christina

On 04/15/2016 07:03 PM, John Magne wrote:
> Subject: [PATCH] Port symkey JNI to Java classes. Ticket #801 : Merge
>   pki-symkey into jss
>
> What is supported:
>
> 1. Everything that is needed to support Secure Channel Protocol 01.
> 2. Supports the nist sp800 kdf and the original kdf.
> 3. Supports key unwrapping used by TPS which was formerly in the symkey JNI.
>
> Requires:
>
> 1. A new JSS that supports more advanced symkey operations such as key derivation, more advanced key
> unwrapping , and a way to list and identify a given symmetric key by name. Version of new Jss will be forthcoming.
>
> Still to do:
>
> 1. Port over the 2 or 3 SCP02 routines from Symkey to use this code.
> 2. The original symkey will remain in place until we can port over everything.
> 3. SCP03 support can be added later.
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160513/edad418c/attachment.htm>
-------------- next part --------------
An embedded message was scrubbed...
From: Christina Fu <cfu at redhat.com>
Subject: review part 1 (JSS)- [PATCH]	0064-Port-symkey-JNI-to-Java-classes.patch
Date: Wed, 4 May 2016 13:40:34 -0700
Size: 6056
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160513/edad418c/attachment.eml>
-------------- next part --------------
An embedded message was scrubbed...
From: Christina Fu <cfu at redhat.com>
Subject: Part 2 review for jmagne's symkey move patch (non-JSS)
Date: Fri, 6 May 2016 19:47:48 -0700
Size: 8841
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20160513/edad418c/attachment-0001.eml>