[Pki-devel] [PATCH] pki-cfu-0122-Ticket-1527-reopened-retrieved-wrong-ca-connector-co.patch

[John Magne]

Looks good.

If tested to work conditional ACK.

Just one thing, when throwing a TPSException at the end of the patch,
please give it the error code, TPSStatus.STATUS_ERROR_CONTACT_ADMIN

----- Original Message -----
> From: "Christina Fu" <cfu at redhat.com>
> To: "pki-devel" <pki-devel at redhat.com>
> Sent: Tuesday, May 17, 2016 6:13:01 PM
> Subject: [Pki-devel] [PATCH] pki-cfu-0122-Ticket-1527-reopened-retrieved-wrong-ca-connector-co.patch
> 
> Ticket #1527 (reopened) retrieved wrong ca connector config parameter
>      This ticket was reopened due to retrieving wrong ca connector
> config param under the situation when format is performed during enrollment.
>      The following is attempted:
>      op.enroll.userKey.ca.conn
>      while the following is intended:
>      op.format.userKey.ca.conn
>      In addition, this patch also fixes the following issues;
>      a. reason param name is not conforming: "reason" instead of
> "revokeReason"
>      b. adding default reason to format TPS profiles
>      c. by default mappingResolver.formatProfileMappingResolver resolves
>         to tokenKey, while enroll resolves to userKey.
>         -> now changed the userKey
>      d. if revocation fails during format, it was forgiving.
>         -> now changed so that error is logged in activity log and exception
>            thrown and bail out
> 
> Tested to work.
> 
> thanks,
> Christina
> 
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel