[Pki-devel] [PATCH] 868-871 Added man pages for logging configuration

[Matthew Harmsen]

On 11/17/2016 03:23 PM, Endi Sukma Dewata wrote:
> Attached are patches to clean up and to add man pages for the logging 
> configuration.
>
>
>
> _______________________________________________
> Pki-devel mailing list
> Pki-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/pki-devel

ACK (presuming customization and troubleshooting have been tested) with 
the following caveats:

  * pki-edewata-0868-Removed-unused-subsystem-logging.properties.patch
      o This patch needs to be split into two separate and distinct patches:
          + patch 1 contains base/ca and base/kra changes
          + patch 2 contains base/ocsp, base/tks, and base/tps changes
  * pki-edewata-0869-Updated-logging.properties.patch
      o fine as is
  * pki-edewata-0870-Updated-log4j.properties.patch
      o fine as is
  * pki-edewata-0871-Added-man-pages-for-logging-configuration.patch
      o suggest adding a CUSTOMIZATION section header to the
        pki-logging.5 man page:
          + .SH CUSTOMIZATION

            To customize the logging configuration, copy the default
            logging configuration file into /etc/pki/logging.properties,
            then change the configuration as needed.
      o similarly, I suggest adding the following headers (or something
        similar) to the pki-server-logging.5 man page:
          + .SH CUSTOMIZATION

            To customize JUL configuration, replace the link with a copy
            of the default configuration:
          + .SH TROUBLESHOOTING

            To troubleshoot RESTEasy issues add the following line
            (unless Log4j is installed in Tomcat classpath):
          + .SH TOMCAT LOGGING

            .SS Log4j
          + .SH PKI LOGGING

            .SS Internal Logging
  * Add a separate check-in to 'pki/specs/pki-core.spec' to include the
    man pages in their appropriate RPMS:
      o %files -n pki-base
        ...
        %{_sbindir}/pki-upgrade
        *%{_mandir}/man5/pki-logging.5.gz*
        %{_mandir}/man8/pki-upgrade.8.gz
        ...
      o %files -n pki-server
        ...
        %{_mandir}/man5/pki_default.cfg.5.gz
        *%{_mandir}/man5/pki-server-logging.5.gz**
        *%{_mandir}/man8/pki-server-upgrade.8.gz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20161117/22563ed0/attachment.htm>