[Pki-devel] [PATCH] Fixed pylint errors (re-sent)
Christian Heimes
cheimes at redhat.com
Thu Jun 1 06:30:36 UTC 2017
On 2017-06-01 01:47, Endi Sukma Dewata wrote:
> Just one thing, I was under the impression that we're supposed to remove
> PKIServerUpgradeScriptlet.__init__() altogether.
>
> Christian, could you take a look a this?
Yes, you can safely drop PKIServerUpgradeScriptlet.__init__(). The
method merely performances a super call without additional logic.
Removing the method will silence pylint and shorten the code by three
unnecessary lines.
Christian
--
Christian Heimes
Senior Software Engineer, Identity Management and Platform Security
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/pki-devel/attachments/20170601/fb7742a2/attachment.sig>
More information about the Pki-devel
mailing list