[Pki-devel] [PATCH] Ticket-2619-Allow-CA-to-process-user-signed-CMC-revo.patch

[John Magne]

Have seen a demo of the functionality working , as well as a live
walk through of the code by cfu, highlighting the crucial parts.



Looks good, one quick thing to change.

1.

static ContentInfo getCMCBlob(SignedData signedData, byte[] data) {

Could we just put a check to make sure that one or the other of the params are non null.
Also make sure that both are not null, which would result in a null pointer exception at some point.


ACK with the quick fix for #1


----- Original Message -----
From: "Christina Fu" <cfu at redhat.com>
To: pki-devel at redhat.com
Sent: Wednesday, June 7, 2017 6:16:56 PM
Subject: [Pki-devel] [PATCH]	Ticket-2619-Allow-CA-to-process-user-signed-CMC-revo.patch



This patch is the implementation for ticket https://pagure.io/dogtagpki/issue/2619 Allow CA to process pre-signed CMC revocation non-signing cert requests 

Patch description in patch comment area. 


please review. 

thanks, 

Christina 

_______________________________________________
Pki-devel mailing list
Pki-devel at redhat.com
https://www.redhat.com/mailman/listinfo/pki-devel