[publican-list] Comments in XML files, good, bad, or ugly?

[Jonathan Robie]

Michael Hideo-Smith wrote:
> ----- "Jeff Fearn" <jfearn at redhat.com> wrote:
>
>   
>> From: "Jeff Fearn" <jfearn at redhat.com>
>> To: "publican" <publican-list at redhat.com>
>> Sent: Wednesday, October 15, 2008 2:02:14 PM GMT +10:00 Brisbane
>> Subject: [publican-list] Comments in XML files, good, bad, or ugly?
>>
>> Currently when you run `make clean_ids` any comments using the <!--
>> ... --> format get removed.
>>
>> This was left in place as in some circumstances inline comments break
>> translations as the merging process does not match the msgid. 
>>     
>
> Hi Jeff,
>
> I am in favour of preserving comments during the clean_ids routine. It has always been the in-line comments that break translation.
>
> ie this is bad:
>
> <para>So then <!-- Mary Jane --> Mary said, these codes sample in <!-- BZ443556 --> BZ4333 no worky worky for me. </para>
>
> ie this is good
>
> <!-- Was Mary Jane and was BZ443556 -->
> <para>So then Mary said, this codes sample in BZ4333 no worky worky for me.</para>
>   
+1

Jonathan