[publican-list] --lang vs --langs

Jaromir Hradilek jhradile at redhat.com
Thu Jun 10 21:36:01 UTC 2010


On 06/10/2010 05:49 PM, Jaromir Hradilek wrote:
> On 06/10/2010 03:35 PM, mhideo at redhat.com wrote:
>> On 10/06/2010, at 10:42 PM, Jaromir Hradilek <jhradile at redhat.com> wrote:
>>> On 06/10/2010 12:56 AM, Jeffrey Fearn wrote:
>>>> Joshua Wulf wrote:
>>>>> Another thing I notice is that publican build takes --langs as an
>>>>> argument, while publican package takes --lang.
>>>>>
>>>>> Is this because "package" can only do one language at a time, while
>>>>> "build" can do multiple?
>>>>
>>>> This is correct.
>>>>
>>>> Cheers, Jeff.
>>>>
>>>
>>> That makes sense to me. However, did you consider allowing both --lang
>>> and --langs interchangeably? I mean, it is perfectly OK to document
>>> only one of them where appropriate, but it will definitely spare us
>>> all some otherwise easily avoidable errors.
>>>
>>
>> Feel free to submit a patch :-)
>
> See the attachment! ;-) (Created by typing `diff publican/bin/publican
> publican/bin/publican.orig > publican.diff' in the root directory of the
> publican's latest SVN snapshot.)
>
> However, I didn't have much time to really familiarize myself with the
> source code, so there is probably a smarter way to do this.

Well, the smarter way would be to add the alias directly to the 
Getopt::Long options, and then make all functions use the same form, but 
I did not want to disturb the semantic distinction between the singular 
and plural forms in the code.

-- 
Jaromir Hradilek
Associate Content Author
Engineering Content Services

Red Hat Czech s. r. o.
Purkynova 99, 612 45 Brno
Phone: +420 532 294 326




More information about the publican-list mailing list