[Pulp-dev] RFC: Replace LGTM with github reviews

Sean Myers sean.myers at redhat.com
Mon Oct 3 21:43:50 UTC 2016

Github's new review feature is supported by another new github feature,
protected branches. If wanted to, we could combine the two ideas, and
only push to protected branches if there is at least one approved review
and no review with required changes outstanding.

I think this could be used instead of the "LGTM" label, and can also help
with the notion of "drive-by" reviews, since the UI gives you a clear
distinction between comments that require changes to be made and comments
that do not require changes to be made.

For reference:

Since we've already got support for protected branches, I propose we
enable required reviews, and stop using the LGTM label.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20161003/fa1dd3d0/attachment.sig>

More information about the Pulp-dev mailing list