[Pulp-dev] RFC: Replace LGTM with github reviews

Elyezer Rezende erezende at redhat.com
Tue Oct 4 14:09:29 UTC 2016

+1 on that

We are doing both currently for Pulp Smash. I set the label and approve the
PR, maybe we can move completely to review as well.

On Mon, Oct 3, 2016 at 6:43 PM, Sean Myers <sean.myers at redhat.com> wrote:

> Github's new review feature is supported by another new github feature,
> protected branches. If wanted to, we could combine the two ideas, and
> only push to protected branches if there is at least one approved review
> and no review with required changes outstanding.
> I think this could be used instead of the "LGTM" label, and can also help
> with the notion of "drive-by" reviews, since the UI gives you a clear
> distinction between comments that require changes to be made and comments
> that do not require changes to be made.
> For reference:
> https://help.github.com/articles/about-pull-request-reviews/
> Since we've already got support for protected branches, I propose we
> enable required reviews, and stop using the LGTM label.
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev

Elyézer Rezende
Senior Quality Engineer
irc: elyezer
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20161004/8f9cc9eb/attachment.htm>

More information about the Pulp-dev mailing list