[Pulp-dev] RFC: Replace LGTM with github reviews

Austin Macdonald amacdona at redhat.com
Tue Oct 4 15:06:04 UTC 2016

On 10/03/2016 05:43 PM, Sean Myers wrote:
> Github's new review feature is supported by another new github feature,
> protected branches. If wanted to, we could combine the two ideas, and
> only push to protected branches if there is at least one approved review
> and no review with required changes outstanding.
> I think this could be used instead of the "LGTM" label
I don't disagree, but I do like being able to see whether a PR has been
approved or not at a glance in the PR list.
> , and can also help
> with the notion of "drive-by" reviews, since the UI gives you a clear
> distinction between comments that require changes to be made and comments
> that do not require changes to be made.
> For reference:
> https://help.github.com/articles/about-pull-request-reviews/
> Since we've already got support for protected branches, I propose we
> enable required reviews, and stop using the LGTM label.
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 847 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20161004/dda64055/attachment.sig>

More information about the Pulp-dev mailing list