[Pulp-dev] Proposal to use google style docstrings (PUP-2)

Patrick Creech pcreech at redhat.com
Tue Apr 18 14:19:05 UTC 2017


+0

On Tue, 2017-04-18 at 10:06 +0200, Tatiana Tereshchenko wrote:
> +0
> 
> Tanya
> 
> On Mon, Apr 17, 2017 at 11:43 PM, David Davis <daviddavis at redhat.com> wrote:
> > +0
> > 
> > 
> > David
> > 
> > On Mon, Apr 17, 2017 at 4:32 PM, Bihan Zhang <bizhang at redhat.com> wrote:
> > > +1
> > > 
> > > On Mon, Apr 17, 2017 at 4:24 PM, Michael Hrivnak <mhrivnak at redhat.com> wrote:
> > > > +0
> > > > 
> > > > On Mon, Apr 17, 2017 at 1:53 PM, Austin Macdonald <austin at redhat.com> wrote:
> > > > > +1
> > > > > 
> > > > > P.S. I want to set the precedent that PUP writers should vote explicitly.
> > > > > 
> > > > > On Mon, Apr 17, 2017 at 1:47 PM, Daniel Alley <dalley at redhat.com> wrote:
> > > > > > +1 from me as well
> > > > > > 
> > > > > > On Mon, Apr 17, 2017 at 1:20 PM, Brian Bouterse <bbouters at redhat.com> wrote:
> > > > > > > +1 to accepting this proposal.
> > > > > > > 
> > > > > > > I left my final round of very small language nitpicks.
> > > > > > > 
> > > > > > > On Wed, Apr 12, 2017 at 2:31 PM, Austin Macdonald <austin at redhat.com> wrote:
> > > > > > > > Thanks to everyone for thoughtful comments and suggestions. Since the comments and
> > > > > > > > changes are still rolling in, we are going to extend the vote.
> > > > > > > > 
> > > > > > > > Voting will take place April 17 at 9pm UTC [0]. 
> > > > > > > > 
> > > > > > > > [0]: http://bit.ly/2ophhod
> > > > > > > > 
> > > > > > > > On Mon, Apr 10, 2017 at 6:40 PM, Brian Bouterse <bbouters at redhat.com> wrote:
> > > > > > > > > I left many comments. Mostly language and clarification requests.
> > > > > > > > > 
> > > > > > > > > Since there are so many comments the pull request is a bit unreadable. FYI, you
> > > > > > > > > can see a rendered version of the current state here:  https://github.com/asmacdo/
> > > > > > > > > pups/blob/google-docstrings/pup-0002.md
> > > > > > > > > 
> > > > > > > > > Thanks @asmacdo for leading this.
> > > > > > > > > 
> > > > > > > > > -Brian
> > > > > > > > > 
> > > > > > > > > On Mon, Apr 10, 2017 at 2:14 PM, Austin Macdonald <austin at redhat.com> wrote:
> > > > > > > > > > PUP 2 [0] is still getting feedback and changing, so we are extending the vote
> > > > > > > > > > to April 12 at 9pm UTC [1]. Voting procedure is described in PUP 1. [2]
> > > > > > > > > > 
> > > > > > > > > > Comments, nitpicks, and votes are welcome from anyone who is interested!
> > > > > > > > > > 
> > > > > > > > > > [0] - https://github.com/pulp/pups/pull/2
> > > > > > > > > > [1] - http://bit.ly/2oXOREo
> > > > > > > > > > [2] - https://github.com/pulp/pups/blob/master/pup-0001.md#voting
> > > > > > > > > > 
> > > > > > > > > > _______________________________________________
> > > > > > > > > > Pulp-dev mailing list
> > > > > > > > > > Pulp-dev at redhat.com
> > > > > > > > > > https://www.redhat.com/mailman/listinfo/pulp-dev
> > > > > > > > > > 
> > > > > > > > > 
> > > > > > > > > 
> > > > > > > > 
> > > > > > > > 
> > > > > > > > _______________________________________________
> > > > > > > > Pulp-dev mailing list
> > > > > > > > Pulp-dev at redhat.com
> > > > > > > > https://www.redhat.com/mailman/listinfo/pulp-dev
> > > > > > > > 
> > > > > > > 
> > > > > > > 
> > > > > > > _______________________________________________
> > > > > > > Pulp-dev mailing list
> > > > > > > Pulp-dev at redhat.com
> > > > > > > https://www.redhat.com/mailman/listinfo/pulp-dev
> > > > > > > 
> > > > > > 
> > > > > > 
> > > > > 
> > > > > 
> > > > > _______________________________________________
> > > > > Pulp-dev mailing list
> > > > > Pulp-dev at redhat.com
> > > > > https://www.redhat.com/mailman/listinfo/pulp-dev
> > > > > 
> > > > 
> > > > 
> > > > 
> > > > -- 
> > > > Michael Hrivnak
> > > > Principal Software Engineer, RHCE 
> > > > Red Hat
> > > > 
> > > > _______________________________________________
> > > > Pulp-dev mailing list
> > > > Pulp-dev at redhat.com
> > > > https://www.redhat.com/mailman/listinfo/pulp-dev
> > > > 
> > > 
> > > 
> > > _______________________________________________
> > > Pulp-dev mailing list
> > > Pulp-dev at redhat.com
> > > https://www.redhat.com/mailman/listinfo/pulp-dev
> > > 
> > 
> > 
> > _______________________________________________
> > Pulp-dev mailing list
> > Pulp-dev at redhat.com
> > https://www.redhat.com/mailman/listinfo/pulp-dev
> > 
> 
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20170418/474ee513/attachment.sig>


More information about the Pulp-dev mailing list