[Pulp-dev] Proposal to remove 'notes' fields from the Pulp 3 RC

Daniel Alley dalley at redhat.com
Tue Dec 4 04:32:58 UTC 2018


"Notes" are a generic key value store where data can be attached to
repositories and content and publications and so forth.  The eventual plan
is to use this to enable adding tags to those sorts of objects, which is
important for Katello.

Most of the code for this is located in pulp/app/models/generic.py


"Notes" have been in Pulp 3 for a very very long time and are completely
unchanged for the last 12 months (the git history doesn't go back further
because the file was moved).  The data model behind it is extremely complex
and while we have a few unit tests around it, we have no functional tests
for it whatsoever, and (to my knowledge) we haven't been using/exercising
this functionality manually in a meaningful way (if at all).  I could be
wrong here, but I haven't seen it discussed  or any issues related to it
filed in quite some time.


We should pull out all of the "notes" code (models/generic.py + the fields
on the aforementioned models) until we've had a chance to properly evaluate
our needs and whether the current design fits them.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20181203/f1947824/attachment.htm>

More information about the Pulp-dev mailing list