[Pulp-dev] Github keywords

David Davis daviddavis at redhat.com
Mon Jan 8 15:41:05 UTC 2018


Today, I had a PR[0] that was accidentally closed by another PR[1]. The
issue is that the format we’re using attach our commits to redmine issues
(e.g. 'fixes #1234’) is the exact same format as what Github uses[2].

I’m wondering if we should change our format. I hate to do so but at the
same time, I worry about PRs getting closed by accident in the future.
Thoughts?

[0] https://github.com/pulp/pulp/pull/3245
<https://github.com/pulp/pulp/pull/3245>[1]
https://github.com/pulp/pulp/pull/3252
[2] https://help.github.com/articles/closing-issues-using-keywords/

David
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20180108/af0f1cc9/attachment.htm>


More information about the Pulp-dev mailing list