[Pulp-dev] Branch protection

[Ina Panova]

+1



--------
Regards,

Ina Panova
Software Engineer| Pulp| Red Hat Inc.

"Do not go where the path may lead,
 go instead where there is no path and leave a trail."

On Tue, Jul 10, 2018 at 11:31 PM, Jeff Ortel <jortel at redhat.com> wrote:

> +1
>
>
> On 07/10/2018 02:30 PM, David Davis wrote:
>
> We noticed in Pulp that the 2-master branch has branch protection but only
> to prevent force pushes and deletion. I was wondering if we should also add
> these checks:
>
> - Require an approving review
> - Require status checks (e.g. unit tests, docs test, flake8)
>
> If so, I think we should also do this for all master and 2-master branches
> for all Pulp core repos (where applicable). Does anyone have any thoughts
> or objections?
>
> I’ll leave this discussion open until July 22, 2018.
>
> David
>
>
> _______________________________________________
> Pulp-dev mailing listPulp-dev at redhat.comhttps://www.redhat.com/mailman/listinfo/pulp-dev
>
>
>
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20180711/ad2771bd/attachment.htm>