[Pulp-dev] Co-owning pulp-packaging

[David Davis]

The impetus for this was that non-release engineers were submitting PRs
against pulp-packaging that were then being merged without having the
release team review them. Pulp organization admins have the commit bit to
all projects including pulp_packaging. So the “co” part of co-ownership
refers to us submitting PRs and the release team approving/merging them.
Maybe not the best choice of words but hopefully that makes sense.

David


On Fri, Jul 20, 2018 at 2:49 PM Robin Chan <rchan at redhat.com> wrote:

> I'm confused by the "co" part of co-ownership.
>
> The Release team and the 2 members of that team are the only admins on
> this git project..
> So there are no other "co" owners from the git teams perspective. Sorry if
> that's a dumb question.
>
> On Thu, Jul 12, 2018 at 1:47 PM, Dana Walker <dawalker at redhat.com> wrote:
>
>> +1
>>
>> This seems like a good move.
>>
>> Dana Walker
>>
>> Associate Software Engineer
>>
>> Red Hat
>>
>> <https://www.redhat.com>
>> <https://red.ht/sig>
>>
>> On Thu, Jul 12, 2018 at 12:58 PM, David Davis <daviddavis at redhat.com>
>> wrote:
>>
>>> I’ve talked to the release engineering team and they’d like to co-own
>>> the pulp-packaging project with us—meaning that they’ll review and sign off
>>> on our PRs. To do this, we can leverage the CODEOWNERS feature of Github[0]
>>> and I’ve opened the following PR:
>>>
>>> https://github.com/pulp/pulp-packaging/pull/49
>>>
>>> <https://github.com/pulp/pulp-packaging/pull/49>Feedback welcome. I’ll
>>> wait until July 20th before proceeding.
>>>
>>> [0] https://help.github.com/articles/about-codeowners/
>>>
>>> David
>>>
>>> _______________________________________________
>>> Pulp-dev mailing list
>>> Pulp-dev at redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>>>
>>
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20180720/2377866d/attachment.htm>