[Pulp-dev] Importer Name

[David Davis]

I’m probably -0 on changing the name from Importer to Remote. I think
Remote is a better name but I worry about changing the data model too much
in respect to Pulp 2. The more we diverge from Pulp 2, the more work we
create for stuff like Katello. The word “importer" appears 500 times in
their codebase. Sure, it might just be a find-and-replace in most cases but
when you combine all the other model changes we’ve made (repository
versions, unlinking publishers/importers from repos, using hrefs instead of
ids, etc) it adds up. I think getting Katello onto Pulp 3’s REST API and
creating a tool to migrate data from Pulp 2 is going to be a bit of a
nightmare.


David

On Sat, Mar 10, 2018 at 11:12 AM, Daniel Alley <dalley at redhat.com> wrote:

> +1 +1
>
> On Fri, Mar 9, 2018 at 3:28 PM, Brian Bouterse <bbouters at redhat.com>
> wrote:
>
>> I left some responses inline.
>>
>> On Thu, Mar 8, 2018 at 11:13 AM, Austin Macdonald <austin at redhat.com>
>> wrote:
>>
>>> Motivation:
>>> The name "importer" carries some inaccurate implications.
>>> 1) Importers should "import". Tasks like "sync" will do the actual
>>> importing. The object only holds the configuration that happens to be used
>>> by sync tasks.
>>> 2) Sync tasks on mirror mode remove content as well as add it, so
>>> "import" isn't quite right.
>>>
>>> Proposed name: Remote
>>>
>>> The inspiration for remote is "git remote". In git, remotes represent
>>> external repositories, which is almost exactly what our importers do.
>>>
>>
>> I'm +0 thinking that either name is fine but that those unfamiliar with
>> git, but those familiar with git would benefit from the name change.
>>
>>
>>>
>>> -------------------------------------------------------
>>> Part 2: Trim the fields
>>>
>>> Currently, Importers have settings that can be categorized in 2 ways. I
>>> am proposing removing the "sync settings" from the Remote model:
>>>
>>> External Source information
>>>     name
>>>     feed_url
>>>     validate
>>>     ssl_ca_certificate
>>>     ssl_client_certificate
>>>     ssl_client_key
>>>     ssl_validation
>>>     proxy_url
>>>     username
>>>     password
>>>
>>> Sync settings
>>>     download_policy
>>>     sync_mode
>>>
>>> This had some advantages when Importers were related to Repositories.
>>> For example, having a repository.importer that always used the same sync
>>> mode made sense. However, the "how" to sync settings don't make much sense
>>> when importers and repositories are not linked. It seems very reasonable
>>> that a user might have 2 repositories that sync from the same source (ex
>>> EPEL). It does not make sense for them to have create an Importer for the
>>> EPEL repository twice or more just to change sync_mode or download policy.
>>> Instead of modeling these fields, I propose that they should POST body
>>> parameters.
>>>
>>> example
>>>
>>> POST v3/remotes/1234/sync/ repositorty=myrepo_href sync_mode=additive,
>>> dl_policy=immediate
>>> POST v3/remotes/1234/sync/ repositorty=myother_href sync_mode=mirror,
>>> dl_policy=deferred
>>>
>>
>> +1 to this change. I think this makes sense to specify the sync_mode and
>> dl_policy with sync params with each download because the Importer having
>> one policy apply to any repo that uses it does not make much sense.
>>
>>
>>>
>>>
>>> _______________________________________________
>>> Pulp-dev mailing list
>>> Pulp-dev at redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>>>
>>
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20180310/ab8a406b/attachment.htm>