[Pulp-dev] [Breaking] Stopping the installer from auto-creating migrations - Sept 3rd

Mike DePaulo mikedep333 at redhat.com
Tue Aug 27 19:30:37 UTC 2019


Yes, just create a pulpcore PR that removes the makemigrations line, as
well as the line above it.
(Honestly, comment the line above it out. We may want the list of plugins
in the future.)

On Tue, Aug 27, 2019 at 3:14 PM Brian Bouterse <bmbouter at redhat.com> wrote:

>
>
> On Tue, Aug 27, 2019 at 3:04 PM Mike DePaulo <mikedep333 at redhat.com>
> wrote:
>
>> Note that we makemigrations & migrate at pulp-api container start
>> time. And all the containers (e.g., pulp-content) wait on the pulp-api
>> container to do them:
>>
>> https://github.com/pulp/pulpcore/blob/master/containers/images/pulp/container-assets/pulp-api#L11
>>
>> Once I took over the containers, I envisioned both of these as a
>> temporary measure. Presumably there would be a separate
>> spordically-run container to perform migrations.
>>
> Can we continue to have the container stuff "migrate" but not
> "makemigrations" along with this change in the installer? My goal is to
> keep the containers and installer consistent.
>
>
>> On Tue, Aug 27, 2019 at 2:41 PM Brian Bouterse <bmbouter at redhat.com>
>> wrote:
>> >
>> > Excellent and good catch on the duplicate already on sprint. Yes let's
>> use 5321 as you suggest. I added to that issue that this was announced and
>> scheduled for Sept 3rd.
>> >
>> > If it's still at NEW on the 3rd, I have a reminder to make a PR and
>> merge on that day. Otherwise anyone can make a PR ahead of time and merge
>> on the 3rd.
>> >
>> > On Tue, Aug 27, 2019 at 2:19 PM Austin Macdonald <austin at redhat.com>
>> wrote:
>> >>
>> >> This all sounds good to me. FYI, I closed
>> https://pulp.plan.io/issues/5361 as a dupe since
>> https://pulp.plan.io/issues/5321 has already been added to the sprint.
>> Feel free to use 5361 and close 5321 if you prefer.
>> >>
>> >> On Tue, Aug 27, 2019 at 2:16 PM Brian Bouterse <bmbouter at redhat.com>
>> wrote:
>> >>>
>> >>> tl;dr if we make this change on Sept 3rd, the installer won't
>> auto-create migrations anymore. For every change needing a migration,
>> please commit one.
>> >>>
>> >>> # Background
>> >>> We enabled the installer to "auto-create" migrations as a solution to
>> the problem of them changing a crazy amount early on in Pulp3's
>> development. Now the migrations are expected to be checked in and I believe
>> they are for all plugins. This is only a breaking change for a plugin that
>> is missing migrations.
>> >>>
>> >>> # The Problem
>> >>> https://pulp.plan.io/issues/5361 This was originally reported by
>> Katello as a P2; I added details to it.
>> >>>
>> >>> # Feedback
>> >>> If there is something better that we should do please suggest it on
>> the issue. If this is a concern or not going to work for you or our users
>> please bring that up anywhere.
>> >>>
>> >>> # Timeline
>> >>> If there are no blocking concerns, I plan to make this change on
>> Tuesday Sept 3rd.
>> >>>
>> >>> Thank you!
>> >>> Brian
>> >>>
>> >>> _______________________________________________
>> >>> Pulp-dev mailing list
>> >>> Pulp-dev at redhat.com
>> >>> https://www.redhat.com/mailman/listinfo/pulp-dev
>> >
>> > _______________________________________________
>> > Pulp-dev mailing list
>> > Pulp-dev at redhat.com
>> > https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>>
>>
>> --
>>
>> Mike DePaulo
>>
>> He / Him / His
>>
>> Service Reliability Engineer, Pulp
>>
>> Red Hat
>>
>> IM: mikedep333
>>
>> GPG: 51745404
>>
>

-- 

Mike DePaulo

He / Him / His

Service Reliability Engineer, Pulp

Red Hat <https://www.redhat.com/>

IM: mikedep333

GPG: 51745404
<https://www.redhat.com/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20190827/7c369be5/attachment.htm>


More information about the Pulp-dev mailing list