[Pulp-dev] RPM mirror repository

[Brian Bouterse]

I haven't looked very closely yet, but I see that the PR [1] has a
conditional check in `finalize_new_version` here:
https://github.com/pulp/pulp_rpm/pull/1568/files#diff-886596b2b9cc3257ce61648f8aab8ebfR124

When finalize_new_version was added, an issue came up similar to yours:
"where should we put validation/checks that should only run some of the
time"? I believe the consensus was that finalize_new_version should only
contain checks that are safe to run in all situations. Plugin writers still
need checks that can only be run during certain user operations, and so we
filed this https://pulp.plan.io/issues/5708 as a plugin API feature request.

Can you read https://pulp.plan.io/issues/5708 and let us know if that would
help you towards your goal?

Thanks,
Brian

On Thu, Dec 19, 2019 at 12:16 PM Pavel Picka <ppicka at redhat.com> wrote:

> As working on RPM feature to mirror repository[1], it needs to bypass
> the resolve_advisory check. That means argument (if it is mirror or
> not) must be passed to Repositorys' new_version.
>
> I ran into part where pulpcore needs to updated [0] that this argument
> can be accepted everywhere.
>
> I'd like to avoid crashing other plugins which use the mirror feature
> so bringing this up to discussion how we want/can process this part.
>
>
> [0]
> https://github.com/pulp/pulpcore/compare/master...pavelpicka:5738-mirror-repo
> [1] https://github.com/pulp/pulp_rpm/pull/1568/files
>
> --
> Pavel Picka
> Red Hat
>
>
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20191220/d01f10d8/attachment.htm>