[Pulp-dev] filtering tasks by reserved resources
dkliban at redhat.com
Fri Jul 12 12:32:55 UTC 2019
I updated the story with the changes I proposed earlier.
On Thu, Jul 11, 2019 at 4:55 PM David Davis <daviddavis at redhat.com> wrote:
> I was thinking the same thing. @dalley also had the suggestion to store
> reserved resources in Redis and have ReservedResource be the historical
> On Thu, Jul 11, 2019 at 4:46 PM Dennis Kliban <dkliban at redhat.com> wrote:
>> On Thu, Jul 11, 2019 at 4:21 PM David Davis <daviddavis at redhat.com>
>>> ReservedResources are unique and the tasking code relies on this
>>> uniqueness to prevent race conditions. The db transaction prevents two
>>> workers from acquiring a lock on the same resource. I read through 5120 but
>>> I am not sure how the design would prevent that from happening?
>>> Thanks for pointing this out. How about creating a separate model for
>> keeping track of historical CreatedResource - TaskCreatedResource? We can
>> worry about improving the tasking system performance in a separate story.
>>> On Thu, Jul 11, 2019 at 4:04 PM Dennis Kliban <dkliban at redhat.com>
>>>> I just wrote up a story to add an ability to filter Tasks by the
>>>> resources that they reserved. This is needed for the migration plan tasks
>>>> and will be just as useful for other tasks.
>>>> The design requires storing ReservedResources permanently in the
>>>> database. The status of the task associated with the ReservedResource will
>>>> be used to determine if a ReservedResource is still active or not.
>>>> Additionally it will no longer be necessary to dispatch a task for removing
>>>> the ReservedResource. Pulp will no longer have to dispatch 2 tasks for
>>>> every single task with a reservation.
>>>> What questions or concerns do you have?
>>>>  https://pulp.plan.io/issues/5120
>>>> Pulp-dev mailing list
>>>> Pulp-dev at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pulp-dev