[Pulp-dev] black

[Austin Macdonald]

On Tue, Jun 4, 2019 at 1:46 PM David Davis <daviddavis at redhat.com> wrote:

> @asmacdo in my original email there is a link to a pulp_rpm PR. Here it is
> again:
>
> https://github.com/pulp/pulp_rpm/pull/1355
>
> I'd be happy to open PRs against pulpcore and/or pulp_file as well.
>
> David
>

Ah, sorry I missed that. I'd like to see what it does to pulpcore before we
make the final call, but unless its terrible +1


>
>
> On Tue, Jun 4, 2019 at 1:41 PM Austin Macdonald <austin at redhat.com> wrote:
>
>> I think there are enough big projects that use black to consider it
>> ready. (PyPI for another example, and we also know it is being actively
>> developed).
>>
>> IMO the way to make this choice is to determine whether the style it
>> uses/enforces works well for the project. There might be legitimate reasons
>> that black would not work for us, a hypothetical example being that our
>> viewset comments must be formatted in a specific way for the autodocs. To
>> move forward, I suggest using black and opening a PR so we can discuss the
>> specifics. In this case, it will be a lot less work to try it out than to
>> consider it theoretically.
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20190604/28dc76db/attachment.htm>