[Pulp-dev] breaking change: accept Null instead of empty string

[Dennis Kliban]

Thanks everyone for the feedback. I made a PR[0].

[0] https://github.com/pulp/pulpcore/pull/135/

On Wed, May 22, 2019 at 7:04 AM Ina Panova <ipanova at redhat.com> wrote:

> +1 to the suggestion.
>
>
> --------
> Regards,
>
> Ina Panova
> Senior Software Engineer| Pulp| Red Hat Inc.
>
> "Do not go where the path may lead,
>  go instead where there is no path and leave a trail."
>
>
> On Tue, May 21, 2019 at 9:10 PM David Davis <daviddavis at redhat.com> wrote:
>
>> This makes sense to me. +1.
>>
>> David
>>
>>
>> On Tue, May 21, 2019 at 2:54 PM Dana Walker <dawalker at redhat.com> wrote:
>>
>>> +1 null
>>>
>>> Dana Walker
>>>
>>> She / Her / Hers
>>>
>>> Software Engineer, Pulp Project
>>>
>>> Red Hat <https://www.redhat.com>
>>>
>>> dawalker at redhat.com
>>> <https://www.redhat.com>
>>>
>>>
>>>
>>> On Tue, May 21, 2019 at 2:47 PM Tatiana Tereshchenko <
>>> ttereshc at redhat.com> wrote:
>>>
>>>> +1 and +1 to allow only null and not both.
>>>>
>>>> Tanya
>>>>
>>>>
>>>>
>>>> On Tue, May 21, 2019 at 7:10 PM Brian Bouterse <bbouters at redhat.com>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Tue, May 21, 2019 at 12:25 PM Dennis Kliban <dkliban at redhat.com>
>>>>> wrote:
>>>>>
>>>>>> Pulp 3's REST API does not accept Null as a value for a string field.
>>>>>> The only way for a user to unset a string field is to pass in an empty
>>>>>> string. This makes it awkward to integrate Pulp with other systems that use
>>>>>> Null to represent unset fields. We discovered this usability problem when
>>>>>> investigating issue with the bindings[0].
>>>>>>
>>>>>> I propose that we switch all fields in pulpcore's REST API to accept
>>>>>> null instead of empty strings and raise a validation error when an empty
>>>>>> string is passed.
>>>>>>
>>>>>> Does this change make sense? Does anyone have objections?
>>>>>>
>>>>> This makes sense to me. +1 to adopting this in core and all plugins.
>>>>>
>>>>>
>>>>>> [0] https://pulp.plan.io/issues/4676
>>>>>>
>>>>>>
>>>>>>  - Dennis
>>>>>> _______________________________________________
>>>>>> Pulp-dev mailing list
>>>>>> Pulp-dev at redhat.com
>>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>>>>
>>>>> _______________________________________________
>>>>> Pulp-dev mailing list
>>>>> Pulp-dev at redhat.com
>>>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>>>
>>>> _______________________________________________
>>>> Pulp-dev mailing list
>>>> Pulp-dev at redhat.com
>>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>>
>>> _______________________________________________
>>> Pulp-dev mailing list
>>> Pulp-dev at redhat.com
>>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>>
>> _______________________________________________
>> Pulp-dev mailing list
>> Pulp-dev at redhat.com
>> https://www.redhat.com/mailman/listinfo/pulp-dev
>>
> _______________________________________________
> Pulp-dev mailing list
> Pulp-dev at redhat.com
> https://www.redhat.com/mailman/listinfo/pulp-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/pulp-dev/attachments/20190522/72602ff5/attachment.htm>